Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-Axis Disagreement #117

Closed
mgaudet opened this issue Feb 13, 2019 · 5 comments
Closed

X-Axis Disagreement #117

mgaudet opened this issue Feb 13, 2019 · 5 comments

Comments

@mgaudet
Copy link

mgaudet commented Feb 13, 2019

Visit https://arewefastyet.com/win10/tp6-amazon?numDays=36, and scroll down
Notice that the X axes don't seem to agree:

image

@armenzg
Copy link
Contributor

armenzg commented Apr 25, 2019

Hi @mgaudet I completely missed this. My apologies.

This has to do with how much data Perfherder has for a specific test. On that screenshot the ttfi did not have data before February.

If it helps visually we could investigate making the X-axis always start at the same place for all the graphs regardless if there's data. I'm leaning toward not fixing, however, I'm happy to mentor any interested contributor.

If we go to Perfherder for dcf and fcp we can tell that the AWFY graphs X-axis match with Perfherder:
https://treeherder.mozilla.org/perf.html#/graphs?timerange=31536000&series=mozilla-central,1870468,1,10
https://treeherder.mozilla.org/perf.html#/graphs?timerange=31536000&series=mozilla-central,1870464,1,10
image
image
image

@divyanshu-rawat
Copy link
Collaborator

@armenzg 👋 what this is about is it open to work on ?

@armenzg
Copy link
Contributor

armenzg commented Jan 6, 2020

Hi!
I would honestly close this.

This is only noticeable when a new benchmark is added and there's less than 60 days worth of data (the default timerange).

If you load a full year you can notice it for some benchmarks. One of them starts from January while the other one starts from July (see screenshot).
image

@divyanshu-rawat
Copy link
Collaborator

@armenzg cool, so what is the proposed solution from youe end?

@armenzg armenzg closed this as completed Jan 6, 2020
@armenzg
Copy link
Contributor

armenzg commented Jan 6, 2020

Closing the issue.

Issue #195 is the next available issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants