Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Automatically synchronize photon assets with upstream photon design lib #817

Closed
mcomella opened this issue Sep 19, 2018 · 3 comments
Closed
Labels
<icons> Components: ui-icons, browser-icons

Comments

@mcomella
Copy link
Contributor

mcomella commented Sep 19, 2018

The canonical source for photon assets is here: https://github.com/FirefoxUX/photon-icons/ These get pulled into the android-components. However, sometimes changes are made in this repository on these assets that don't get reflected upstream, e.g. #766 and #778.

We should come up with a system that either:

  • Prevents changes to these assets directly in this repository, encouraging users to contribute upstream (maybe a Danger check to add a warning if the photon module is modified?)
  • Automatically synchronizes any changes in this repository to the photon assets upstream

┆Issue is synchronized with this Jira Task

@pocmo
Copy link
Contributor

pocmo commented Sep 21, 2018

This is tracked "upstream" here:
FirefoxUX/photon-icons#23

@pocmo pocmo added the <icons> Components: ui-icons, browser-icons label Sep 21, 2018
@pocmo
Copy link
Contributor

pocmo commented Sep 21, 2018

Note that photon-icons uses an automated process to generated the XML drawables while multiple of our icons are manually optimized to fix various issues.

@data-sync-user data-sync-user changed the title Automatically synchronize photon assets with upstream photon design lib FNX3-22878 ⁃ Automatically synchronize photon assets with upstream photon design lib Aug 5, 2020
@st3fan st3fan changed the title FNX3-22878 ⁃ Automatically synchronize photon assets with upstream photon design lib Automatically synchronize photon assets with upstream photon design lib Aug 5, 2020
@csadilek
Copy link
Contributor

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1793167

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<icons> Components: ui-icons, browser-icons
Projects
None yet
Development

No branches or pull requests

3 participants