The Change Passcode and Require Passcode options are not grayed out when Passcode is OFF

[abodea]

Steps to reproduce

1. Launch Firefox.
2. Reach settings and then Face ID & Passwords.
3. Turn the passcode OFF.
4. Observe the Change Passcode and Require Passcode.

Expected behavior

The Change Passcode and Require Passcode options should be grayed out while the Passcode is OFF.

Actual behavior

The Change Passcode and Require Passcode options are not grayed out when the Passcode is OFF.

Device information

• Device: iPad Pro (13.3)
• Fenix version: v23.0(17297)

[nishant2718]

I see this issue in prod on iPhone iOS 13.3 as well. I'll start looking into it.

[vphong]

I think I've pinpointed the problem on this.

When a passcode is added or removed, we call this selector using NotificationCenter.

firefox-ios/Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift

Lines 325 to 329 in 512e03c

	@objc func refreshSettings(_ notification: Notification) {
	updateTitleForTouchIDState()
	settings = generateSettings()
	tableView.reloadData()
	}

but generateSettings() does not do anything with the notification.

firefox-ios/Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift

Lines 236 to 242 in 512e03c

	override func generateSettings() -> [SettingSection] {
	if let _ = KeychainWrapper.sharedAppContainerKeychain.authenticationInfo() {
	return passcodeEnabledSettings()
	} else {
	return passcodeDisabledSettings()
	}
	}

I'm not totally sure about the best way to expose/send the notification to generateSettings(), so I hesitate to work on a fix. Any thoughts?

[KrystynaKruchkovska]

There is an open request already, textLabel?.textColor = UIColor.theme.tableView.rowText set after correct one.

[vphong]

Apologies, you're right! #6250 does fix the problem.

[dnarcese]

Fixed in #6250