Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text visibility issues in Settings page when forcing Light theme #6352

Closed
csuciu opened this issue Apr 2, 2020 · 4 comments
Closed

Text visibility issues in Settings page when forcing Light theme #6352

csuciu opened this issue Apr 2, 2020 · 4 comments
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected

Comments

@csuciu
Copy link

csuciu commented Apr 2, 2020

master 8350f11
iPhone 11 Pro 13.3

  1. Enable iOS Dark theme.
  2. Enable Light theme in Firefox settings.
  3. in Firefox settings, check the Theme, Search and Data Management pages.

Results: In this pages, only the sections titles are visible.

┆Issue is synchronized with this Jira Task

@dnarcese
Copy link
Contributor

dnarcese commented Apr 7, 2020

@csuciu does the text reappear when you re-open this page? Or restart the app? Or is the only way to fix it to change the theme back.

@csuciu csuciu added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Apr 8, 2020
@csuciu
Copy link
Author

csuciu commented Apr 10, 2020

@dnarcese the only way to fix it is to change the theme back. Restarting the app doesn't change anything.

@ciccioska
Copy link

ciccioska commented May 15, 2020

A problem on this is also available if you set the App to use the system theme. In this transition, with the App opened and in the background, the colour of the menu is not correct.

IMG_4388

@tomislaveric
Copy link
Contributor

I could reproduce the issue, i've created a PR with a one liner fix! #6678
enjoy!

@data-sync-user data-sync-user changed the title Text visibility issues in Settings page when forcing Light theme FXIOS-327 ⁃ Text visibility issues in Settings page when forcing Light theme Oct 17, 2020
@dnarcese dnarcese closed this as completed Nov 1, 2021
@data-sync-user data-sync-user changed the title FXIOS-327 ⁃ Text visibility issues in Settings page when forcing Light theme Text visibility issues in Settings page when forcing Light theme Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected
Projects
None yet
Development

No branches or pull requests

4 participants