diff --git a/ClientTests/ClientTests.swift b/ClientTests/ClientTests.swift index 0e0a8812fb0a..526f1df73d3e 100644 --- a/ClientTests/ClientTests.swift +++ b/ClientTests/ClientTests.swift @@ -28,12 +28,14 @@ class ClientTests: XCTestCase { } XCTAssertTrue(compare(UserAgent.mobileUserAgent()), "User agent computes correctly.") } - - func testDesktopUserAgent() { - let compare: (String) -> Bool = { ua in - let range = ua.range(of: "^Mozilla/5\\.0 \\(Macintosh; Intel Mac OS X [0-9\\.]+\\)", options: .regularExpression) - return range != nil - } - XCTAssertTrue(compare(UserAgent.desktopUserAgent()), "Desktop user agent computes correctly.") - } + + // Disabling for now due to https://github.com/mozilla-mobile/firefox-ios/pull/6468 + // This hard-codes the desktop UA, not much to test as a result of that +// func testDesktopUserAgent() { +// let compare: (String) -> Bool = { ua in +// let range = ua.range(of: "^Mozilla/5\\.0 \\(Macintosh; Intel Mac OS X [0-9\\.]+\\)", options: .regularExpression) +// return range != nil +// } +// XCTAssertTrue(compare(UserAgent.desktopUserAgent()), "Desktop user agent computes correctly.") +// } } diff --git a/Shared/UserAgent.swift b/Shared/UserAgent.swift index d71cc0c2e501..0b945ecc71c7 100644 --- a/Shared/UserAgent.swift +++ b/Shared/UserAgent.swift @@ -43,7 +43,7 @@ open class UserAgent { } public static func desktopUserAgent() -> String { - return UserAgentBuilder.defaultDesktopUserAgent().userAgent() + return "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15" } public static func mobileUserAgent() -> String { @@ -62,11 +62,7 @@ open class UserAgent { public static func getUserAgent(domain: String, platform: UserAgentPlatform) -> String { switch platform { case .Desktop: - if let customUA = CustomUserAgentConstant.desktopUserAgent[domain] { - return customUA - } else { - return desktopUserAgent() - } + return desktopUserAgent() case .Mobile: if let customUA = CustomUserAgentConstant.mobileUserAgent[domain] { return customUA @@ -98,11 +94,7 @@ public struct CustomUserAgentConstant { public static let mobileUserAgent = [ "paypal.com": defaultMobileUA, "yahoo.com": defaultMobileUA ] - public static let desktopUserAgent = [ - "paypal.com": customDesktopUA, - "yahoo.com": customDesktopUA, - "youtube.com": customDesktopUA, - "whatsapp.com": customDesktopUA ] + } public struct UserAgentBuilder {