Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/releases/xxxxxxx/v2 should be able to create a new release #2994

Open
jcristau opened this issue Oct 5, 2023 · 9 comments
Open

/releases/xxxxxxx/v2 should be able to create a new release #2994

jcristau opened this issue Oct 5, 2023 · 9 comments
Labels
admin admin app & api (aus4-admin.mozilla.org) frontend ui issues

Comments

@jcristau
Copy link
Contributor

jcristau commented Oct 5, 2023

I'm not sure if I'm doing something wrong here, but when trying to create a release I go to e.g. https://balrog.services.mozilla.com/releases/Widevine-4.10.2710.0/v2, then paste or upload the blob, but the form won't let me enter the product name, which means form submission fails. Going into devtools to replay the request having added the product to the request body does work.

@jcristau jcristau added admin admin app & api (aus4-admin.mozilla.org) frontend ui issues labels Oct 5, 2023
@ademolaomosanya
Copy link

i'm an outreachy applicant
and i would like to work on this issue kindly asign me

@Raven49
Copy link

Raven49 commented Oct 7, 2023

Kindly assign this task to me

@bhearsum
Copy link
Contributor

bhearsum commented Oct 24, 2023

@jcristau - can you still reproduce this? I wasn't able to with the latest main.

Is it possible you were on an Update page instead of a Create page? If so, not being able to edit the name is expected.

@jcristau
Copy link
Contributor Author

It's possible I was on an Update page, I don't know the difference :)

@bhearsum
Copy link
Contributor

It's possible I was on an Update page, I don't know the difference :)

The main indication is the page title. The route and UI are otherwise identical.

@jcristau
Copy link
Contributor Author

Thanks, OK, so I guess the bug from my point of view is that /releases/doesnotexist/v2 should give me the "new release" page and pre-fill the name, instead of giving me an "update a release that does not exist and that you can't actually update" page. Does that sound reasonable?

@bhearsum
Copy link
Contributor

Thanks, OK, so I guess the bug from my point of view is that /releases/doesnotexist/v2 should give me the "new release" page and pre-fill the name, instead of giving me an "update a release that does not exist and that you can't actually update" page. Does that sound reasonable?

Yeah, I think that makes sense. I guess the thing that surprises me is how you're getting to a page like that though? I guess it's a manually entered URL, as I don't see how you could get there via the UI.

@jcristau
Copy link
Contributor Author

Correct. Partly because usually the new release I want to create is a variation on an existing one, but there's no "duplicate" button for releases like there is for rules. Partly because the "new release" button is on the /releases page which itself takes forever to load.

@bhearsum bhearsum changed the title can't create a release in the UI /releases/xxxxxxx/v2 should be able to create a new release Oct 27, 2023
@bhearsum
Copy link
Contributor

I've updated the summary to match what we've discussed. It looks like the fix here is going to involve a couple of things:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin admin app & api (aus4-admin.mozilla.org) frontend ui issues
Projects
None yet
Development

No branches or pull requests

4 participants