New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log and lint addon id and version from xpi SignFile #773

Open

7 tasks

g-k opened this issue Sep 28, 2021 · 0 comments

Contributor

g-k commented Sep 28, 2021

Follow up items from comments and original issue:

return parsed ID and version to SignFile in xpi
- log parsed ID and version with the "signing operation succeeded" lines instead of from the repacking code
- when signing in mode ModeAddOn and ModeAddOnWithRecommendation check the lints:
  - warn for a missing manifest.json file
  - warn for multiple IDs: applications.gecko.id and browser_specific_settings.gecko.id
  - warn for manifest ID not matching request Options.ID
  - warn for a missing version

Warnings return errors if we want to do more linting in autograph and other web extension signers pass for legitimate uses.

Originally posted by @g-k in #771 (comment)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment