Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Do not include empty, optional fields in push notifications #1392

Open
jrconlin opened this issue May 12, 2020 · 1 comment
Open

Do not include empty, optional fields in push notifications #1392

jrconlin opened this issue May 12, 2020 · 1 comment
Labels
2 Estimate - s - This is a small change with clearly defined parameters. good first bug

Comments

@jrconlin
Copy link
Member

Client was dropping some messages that don't have con data, which can happen with aes128gcm encoded data content. We should not include empty fields if they're optional.
@jrconlin jrconlin added the 2 Estimate - s - This is a small change with clearly defined parameters. label May 12, 2020
@jonalmeida jonalmeida mentioned this issue May 12, 2020
Closed
@jrconlin
Copy link
Member Author

Ok, so this is a really weird one. Autopush is plenty clear about only allowing valid content-encoding headers through and gleefully returns 400 if it gets something bad.

autopush should not let a blank 'con' go through unless the message has no data. Working with @jonalmeida to sort out what's going on here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
2 Estimate - s - This is a small change with clearly defined parameters. good first bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrconlin