Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added javascript option asyncstack #910

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added javascript option asyncstack #910

wants to merge 3 commits into from

Conversation

Ayushsunny
Copy link
Contributor

@Ayushsunny Ayushsunny commented Apr 30, 2021

Added Set javascript.options.asyncstack to true in the function
def optimize_prefs(prefs: Dict[str, Any]) -> None:
Closes #678

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #910 (b483048) into master (18e1286) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage   51.17%   51.01%   -0.17%     
==========================================
  Files          34       34              
  Lines        3392     3399       +7     
==========================================
- Hits         1736     1734       -2     
- Misses       1656     1665       +9     
Impacted Files Coverage Δ
openwpm/deploy_browsers/configure_firefox.py 8.69% <0.00%> (-0.08%) ⬇️
openwpm/browser_manager.py 71.54% <0.00%> (-1.39%) ⬇️
openwpm/deploy_browsers/deploy_firefox.py 23.07% <0.00%> (-1.10%) ⬇️
openwpm/config.py 95.83% <0.00%> (-0.84%) ⬇️
openwpm/mp_logger.py 67.27% <0.00%> (+0.19%) ⬆️
openwpm/task_manager.py 78.37% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e1286...b483048. Read the comment docs.

@vringar
Copy link
Contributor

vringar commented Apr 30, 2021

Do you want to try and also create a test page that uses setTimeout and assert that we now capture the full callstack as was asked in the last line of the original issue?

@Ayushsunny
Copy link
Contributor Author

Ayushsunny commented Apr 30, 2021

Do you want to try and also create a test page that uses setTimeout and assert that we now capture the full callstack as was asked in the last line of the original issue?

Hello @vringar I know lil bit about setTimeout function but I have no idea how we are gonna implement here.
can you help me with that sir?

@vringar
Copy link
Contributor

vringar commented May 3, 2021

Hey,
please create a HTML page under test/test_pages and create an inline script that uses set timeout before printing to console.
I'll explain further once this is done.

@Ayushsunny
Copy link
Contributor Author

Hey,
please create a HTML page under test/test_pages and create an inline script that uses set timeout before printing to console.
I'll explain further once this is done.

Hello @vringar , So we need something like this ?

@vringar
Copy link
Contributor

vringar commented May 7, 2021

Hey,
I have underestimated the complexity of writing a test for this pref and don't have the time to mentor you on this any further.
I'm sorry about that!
Would it be okay for you to switch to something like #915 or #916 and leave this PR open for a while?

@Ayushsunny
Copy link
Contributor Author

Hey,
I have underestimated the complexity of writing a test for this pref and don't have the time to mentor you on this any further.
I'm sorry about that!
Would it be okay for you to switch to something like #915 or #916 and leave this PR open for a while?

Okay Sir, Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set javascript.options.asyncstack to true
2 participants