Add deleteComment() API and support DELETE responses better #1115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
- Coverage 98.02% 97.98% -0.05%
==========================================
Files 59 59
Lines 2030 2038 +8
Branches 519 523 +4
==========================================
+ Hits 1990 1997 +7
- Misses 30 31 +1
Partials 10 10
Continue to review full report at Codecov.
|
src/api/index.tsx
Outdated
| return callApi<{ | ||
| requestData: undefined; | ||
| successfulResponse: { ok: boolean }; | ||
| }>({ |
There was a problem hiding this comment.
Shouldn't this be GetResource<{ok: boolean}>?
There was a problem hiding this comment.
I guess it could be but it's not a GET request. Also, I couldn't think of a better name for GetResource. EmptyRequestResponse seems weird, heh. Maybe I'll think of one.
There was a problem hiding this comment.
Maybe GetResource could be renamed to Resource?
There was a problem hiding this comment.
Hmm, seems sort of vague. I went with ResponseOnly, let me know what you think.
|
Thanks for the quick review |
Fixes #1114