[Task]: Reviewer tools: Support attaching a zip file to a review

[wagnerand]

Description

To reduce reviewer workload by doing the same task of building an artifact for a developer to check repeatedly and to eliminate the dependency on a third-party service, the reviewer tools should support adding a zip attachment to at least rejections and reviewer replies. If it's not too much additional effort, ideally it should be supported for all actions.

Acceptance Criteria

Milestones/checkpoints

Beta Give feedback

1. A zip file should be attachable to at least reviewer replies and rejections, ideally all reviewer actions.

Checks

• If the issue is ready to work on, I have removed the "needs:info" label.
• If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

[diox]

Let's start with a 100 MB file limit to begin with and see how it goes.

[diox]

Note: zip files should also go through SafeZip like all our zip files.

[wagnerand]

Let's do 200MB. Several dozen versions submitted just this year have XPI files larger than 100MB and at least one of them is Notable.

[diox]

(We did 210 MB / 200 MiB)

Depends on #14997

[ioanarusiczki]

I've errors on dev with 1 + MB zip files, I tried from win and macOS. Same with a larger txt file.

[eviljeff]

@ioanarusiczki large files should be working now (on dev and stage)

[ioanarusiczki]

I tried on dev and stage to make uploads.

Tested on:
https://reviewers.addons.allizom.org/en-US/reviewers/review-listed/1031481
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/633303

What passed: zip files attached to various reviewer actions (can be seen on the links above) of 3, 9, 13, 20, 26, 37 MB
Also a 9MB txt file.

I've noticed that somewhere from 40MB + , I've the 502 server error so it failed with:
44, 48, 50, 116 mb zip files

I tested this on both dev and stage servers.

[ioanarusiczki]

Larger uploads on dev went through for: 50, 120, 150 up to 180+ MB

https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/633177#review-actions

180 plus on stage too https://reviewers.addons.allizom.org/en-US/reviewers/review-listed/1031488#review-actions

At 190 + I'm getting this error

Anything above 200 MB throws the error

[ioanarusiczki]

There's a followup filed #15093

I'm marking this verified since large uploads are now working as mentioned above on dev and stage.