Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Make it possible to add, view or delete soft-blocks in the admin #15013

Closed
3 tasks
diox opened this issue Sep 11, 2024 · 5 comments · Fixed by mozilla/addons-server#22765
Closed
3 tasks
Assignees
Labels
qa:verified_fix repository:addons-server Issue relating to addons-server
Milestone

Comments

@diox
Copy link
Member

diox commented Sep 11, 2024

Description

Depends on #15012

Make it possible to add, view and delete soft-blocks in the admin, with logging about the change.

This is unlikely to be the main way to add or edit soft-blocks in production (reviewer integration should be added later), but this is needed for testing purposes and convenience for edge-cases where an admin might need to quickly add/delete a soft-block.

Acceptance Criteria

Milestones/checkpoints

Checks

  • If the issue is ready to work on, I have removed the "needs:info" label.
  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@diox

This comment was marked as outdated.

@diox

This comment was marked as outdated.

@diox

This comment was marked as outdated.

@diox diox self-assigned this Oct 9, 2024
@diox diox added this to the 2024.10.17 milestone Oct 9, 2024
@diox diox changed the title [Task]: Make it possible to add or edit soft-blocks in the admin [Task]: Make it possible to add, view or delete soft-blocks in the admin Oct 14, 2024
@diox diox modified the milestones: 2024.10.17, 2024.10.31 Oct 25, 2024
@diox diox added repository:addons-server Issue relating to addons-server and removed repository:addons-frontend Issue relating to addons-frontend labels Oct 25, 2024
@ioanarusiczki
Copy link

The ones below did not show up on https://firefox.settings.services.allizom.org/v1/buckets/blocklists/collections/addons-bloomfilters/records

https://addons.allizom.org/en-US/firefox/addon/stats-on-stage-5/versions/
https://addons.allizom.org/en-US/firefox/addon/one-blocked-one-restricted/
https://addons.allizom.org/en-US/firefox/addon/a-restricted/

@ioanarusiczki
Copy link

Today's test results on dev

  • blocked versions showed up in stash and were blocked in the browser
    bloooc

  • restricted versions unblocked did not show up in stash (so far expected)

On stage

  • installed and hard blocked versions showed up in stash and have been blocked in the browser
  • restricted versions are not present in stash and continue to be available in about:addons
  • deleted hard-blocked versions are all present in stash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified_fix repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants