Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Fix dependency resolution in <your-favourite-ide> #15034

Open
1 task
eviljeff opened this issue Sep 19, 2024 · 3 comments
Open
1 task

[Task]: Fix dependency resolution in <your-favourite-ide> #15034

eviljeff opened this issue Sep 19, 2024 · 3 comments
Assignees
Labels

Comments

@eviljeff
Copy link
Member

eviljeff commented Sep 19, 2024

Description

Previously it was possible to have vscode (or another ide) set up so all dependencies referenced in addons-server could be resolved. This meant you could seamlessly inspect the python code for a dependency in the same way you could navigate to a file within addons-server's codebase. Most often this would be a django .py but with all the dependencies there it could be any package. This all "broke" when we stopped installing dependencies in a sub-directory in the addons-server directory (for startup efficiency)

Acceptance Criteria

Milestones/checkpoints

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@eviljeff eviljeff added needs:info repository:addons-server Issue relating to addons-server labels Sep 19, 2024
@diox diox added the local_dev label Sep 19, 2024
@diox
Copy link
Member

diox commented Sep 19, 2024

Ugly workaround we discussed during Office Hours: install deps in a dummy virtualenv and point vscode to that.

Alternatively we could find ways to expose the docker container deps to the host, maybe through a volume like we used to, or maybe though some vscode extension that would deal with docker.

@wagnerand
Copy link
Member

I haven't tried this, but https://stackoverflow.com/a/75560548 looks promising?

@eviljeff
Copy link
Member Author

@KevinMind if #15066 will fix this (in a more comprehensive way) is it worth putting any effort into getting dependency resolution to work with the current setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants