Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Identify dead code in addons-server #15045

Open
2 tasks
KevinMind opened this issue Sep 25, 2024 · 1 comment
Open
2 tasks

[Task]: Identify dead code in addons-server #15045

KevinMind opened this issue Sep 25, 2024 · 1 comment
Labels
needs:info repository:addons-server Issue relating to addons-server

Comments

@KevinMind
Copy link
Contributor

KevinMind commented Sep 25, 2024

Description

We can add a CI check to ensure we remove deadcode from our codebase.

There are tools like https://github.com/jendrikseipp/vulture that can help with this

Acceptance Criteria

Milestones/checkpoints

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@KevinMind KevinMind added needs:info repository:addons-server Issue relating to addons-server labels Sep 25, 2024
@diox
Copy link
Member

diox commented Sep 25, 2024

I'm not sure it's worth the effort depending on how annoying it is to set up, because I'm fairly confident we don't have that much dead code, we've already done a lot of cleanups over the years.

The one thing we may have are obsolete management commands for one-off tasks we then never deleted, but even those we tend to eventually get rid off (some already have issues opened about them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:info repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

2 participants