Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Review verdict submission is fairly slow for certain add-ons #15053

Open
1 task done
abhn opened this issue Sep 27, 2024 · 2 comments
Open
1 task done

[Bug]: Review verdict submission is fairly slow for certain add-ons #15053

abhn opened this issue Sep 27, 2024 · 2 comments

Comments

@abhn
Copy link

abhn commented Sep 27, 2024

What happened?

When submitting reviews for certain add-ons, AMO takes 10 seconds or more of processing time before the action is in our system. This is undesirable as it slows down the review process.

Example AMO ID from @wagnerand: 2809791

What did you expect to happen?

The review verdict submission should go through with minimal processing time (2 seconds or less is desirable)

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@diox
Copy link
Member

diox commented Sep 27, 2024

By nature, there is a lot of variance because of what needs to happen depending on the action, the add-on, the versions etc. It would be interesting to see if this only affects approvals or other types of actions.

This graph shows the POST requests to the review page have gotten slower and with more variations than before since ~July
Screenshot 2024-09-27 at 13-53-14 AMO Reviewer   Admin Tools Performance and Monitoring - AMO - Dashboards - Grafana

Coincidentally, the requests to autograph does seem to have started taking more time since ~July as well (more data since it's also auto-approvals, so slightly less noisy graph):
Screenshot 2024-09-27 at 13-53-34 AMO External Services Performance_Usage - AMO - Dashboards - Grafana

@KevinMind
Copy link
Contributor

Once we determine the plan, we should update this task with said plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants