Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch_bookmark does more queries than we'd like when get_direct_children is true #806

Closed
thomcc opened this issue Mar 19, 2019 · 3 comments · Fixed by #1306
Closed

fetch_bookmark does more queries than we'd like when get_direct_children is true #806

thomcc opened this issue Mar 19, 2019 · 3 comments · Fixed by #1306
Assignees
@thomcc
Labels
good-second-issue Good for contributors, but not necessarially good for newcomers, as they tend to be more involved.

Comments

@thomcc
Copy link
Contributor

thomcc commented Mar 19, 2019 •
edited by cse-test-sync
Loading

One option is to modify fetch_tree so that it's usable in this case. Follow-up from #743

┆Issue is synchronized with this Jira Story
┆Sprint: SYNC - 2019-07-05
@thomcc thomcc added the good-second-issue Good for contributors, but not necessarially good for newcomers, as they tend to be more involved. label Jun 9, 2019
@0x00A5
Copy link
Contributor

0x00A5 commented Jun 15, 2019

I'd like to have a try on this issue.

@0x00A5 0x00A5 mentioned this issue Jun 17, 2019
Merged
@cse-test-sync
Copy link

Transition made by Unito

@cse-test-sync cse-test-sync reopened this Jun 26, 2019
@thomcc
Copy link
Contributor Author

thomcc commented Jun 27, 2019

Hmm, @jdragojevic was this intentionally reopened or was it a casualty in some jira operation?

@thomcc thomcc closed this as completed Jun 27, 2019
@thomcc thomcc removed their assignment Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomcc thomcc

Labels
good-second-issue Good for contributors, but not necessarially good for newcomers, as they tend to be more involved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring fetch_bookmark to avoid extra queries
3 participants
@thomcc @0x00A5 @cse-test-sync