Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the responses library rather than httpd #400

Open
edmorley opened this issue Jul 12, 2016 · 1 comment
Open

Use the responses library rather than httpd #400

edmorley opened this issue Jul 12, 2016 · 1 comment

Comments

@edmorley
Copy link
Contributor

edmorley commented Jul 12, 2016

TestAPI() currently uses httpd to fake out Treeherder API responses, when this could be done much more simply using the responses library:
https://github.com/getsentry/responses

This would also mean the host and protocol arguments to Treeherder could be dropped, since all other consumers of it use the default Treeherder production instance.

@whimboo
Copy link
Contributor

whimboo commented Jul 18, 2016

Sweet. Thanks for this hint @edmorley. I haven't known this package yet. It indeed sounds like a good idea.

@whimboo whimboo added this to the 1.24 milestone Sep 20, 2017
@whimboo whimboo modified the milestones: 1.24, 1.25 Jul 6, 2018
@whimboo whimboo modified the milestones: 1.25, 1.26 Oct 22, 2018
@whimboo whimboo modified the milestones: 1.26, 1.27.0 May 13, 2019
@whimboo whimboo removed this from the 1.27.0 milestone May 7, 2021
@edmorley edmorley closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2024
@whimboo whimboo reopened this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants