Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Proxy Settings PROBLEM! #2278

Closed
elwason29 opened this issue Feb 1, 2022 · 29 comments · Fixed by #2333
Closed

Advanced Proxy Settings PROBLEM! #2278

elwason29 opened this issue Feb 1, 2022 · 29 comments · Fixed by #2333
Labels
bug Something is broken! Component: Proxy Issues related to the proxy functionality

Comments

@elwason29
Copy link

The "Advanced Proxy Settings" option does not change my proxy on any of my containers. Yesterday it worked. I need help please.

@Movva
Copy link

Movva commented Feb 1, 2022

+1

proxy is not applying on container level, suddenly stopped working in middle of work.

@srinidhibs
Copy link

I received the update for version 8.0.5 today and the proxy settings stopped working. The 8.0.5 version contains the fix for #2258 which could be causing this. Also, the addons page now says that I need a newer version of Firefox to run 8.0.5.

Hence, I downgraded back to 8.0.4 and disabled auto-update for this extension. Everything is back to normal.

@elwason29
Copy link
Author

elwason29 commented Feb 1, 2022 via email

@elwason29
Copy link
Author

For those who have the problem you can download the previous version 8.0.4 of the plugin here: https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/versions/

@wishbone1138
Copy link

wishbone1138 commented Feb 2, 2022

Also experienced this, disappointed that this failed open, which impacts what we expect to happen with containers. @groovecoder-mozilla-owner is this part of the new DNS through proxy code in 8.0.5 from this line item:
"fix #2248: proxy DNS too by @groovecoder in #2258"

@wishbone1138
Copy link

I successfully confirmed the bug. Containers use the per container proxy setting in 8.0.4, but upgrading to 8.0.5 they seem to completely ignore it.

@groovecoder groovecoder added bug Something is broken! Component: Proxy Issues related to the proxy functionality labels Feb 9, 2022
@lesleyjanenorton
Copy link
Collaborator

Hi folks, if you could include your platform information (mac, linux, Windows) it would be incredible helpful. Thank you!

@S4ntiagoP
Copy link

I can confirm that the issue exists in Linux

@lesleyjanenorton
Copy link
Collaborator

@groovecoder is currently working on a fix

@groovecoder
Copy link
Member

Fix is in a PR here: #2283

@Lem
Copy link

Lem commented Feb 15, 2022

Hi @groovecoder,

sadly I have to report that the version 8.0.6 (which is available at addons.mozilla.org) does not fix this problem for me. With 8.0.6 traffic is still not going through my proxy (using http://127.0.0.1:8080 in the advanced settings).

Verified it by downgrading to 8.0.4, with this version I see traffic on the proxy.

@Joibel
Copy link

Joibel commented Feb 15, 2022

I am also seeing 8.0.6 behaving the same as 8.0.5. 8.0.4 works.

@Gilgamoth
Copy link

Another one to add that 8.0.6 and 8.0.5 don't route proxy traffic and downgrading to 8.0.4 resolves this.
O/S: Windows
FF: 97.0 (64-bit)

@Gilgamoth
Copy link

Another one to add that 8.0.6 and 8.0.5 don't route proxy traffic and downgrading to 8.0.4 resolves this. O/S: Windows FF: 97.0 (64-bit)

Just updated FF to 97.0.1 and 8.0.5 & 6 still don't route traffic via proxy

@gitviola
Copy link

Happens on MacOS too

@Sol-Illadan
Copy link

Sol-Illadan commented Feb 20, 2022

Another one to add that 8.0.6 and 8.0.5 don't route proxy traffic and downgrading to 8.0.4 resolves this. O/S: Windows FF: 97.0 (64-bit)

Just updated FF to 97.0.1 and 8.0.5 & 6 still don't route traffic via proxy

I use Windows 10 with latest FF & add-on v8.0.6, connecting to a local vpn proxy server; it does not work at all. Managed to get it working by downgrading to 8.0.4

@groovecoder
Copy link
Member

I WAS able to reproduce this bug while trying to proxy a container thru ZAP https - the traffic did NOT go thru ZAP.
I WAS NOT able to reproduce this bug while proxying a container thru Tor socks - the traffic DID go thru Tor.

So a few things to check to help me get the most reliable STR:

  1. Are you running your own proxy on localhost/127.0.0.1?
  2. Are you running a socks proxy or http/s proxy?
  3. Make sure you have network.proxy.allow_hijacking_localhost set to true? (see https://bugzilla.mozilla.org/show_bug.cgi?id=1535581)

@Gilgamoth
Copy link

@groovecoder
In answer to your questions, in my instance:

  1. No, it's a remote TinyProxy implementation
  2. It's a http/s proxy
  3. Not sure this is relevent as I'm not using a local proxy

@wishbone1138
Copy link

@groovecoder

  1. no, it's a remote host, but still on my local subnet RFC 1918 addresses (if that matters)
  2. http/s proxy, also using privoxy
  3. also not using localhost proxy, seems like a good feature to leave off for security

@lowlypalace
Copy link

I can confirm on MacOS 12.2 running Firefox 98.0.1 and Multi Account Containers Version 8.0.6. The proxy feature stopped working after I upgraded. Just downgraded to 8.0.4 and everything started to work as before.

@nekno
Copy link
Contributor

nekno commented Apr 20, 2022

Confirming this is still an issue with HTTP proxies in Multi-Account Containers 8.0.6, macOS 12.3.1, Firefox 99.0.1.

Also had to downgrade to 8.0.4 to get the proxy working in the container again.

  1. No, not running a proxy on localhost, running it on another machine on the LAN
  2. HTTP proxy
  3. network.proxy.allow_hijacking_localhost set to false, but I'm not using localhost, I'm using another LAN IP

@rafalkrupinski
Copy link

Macos 12.3.1
FF 99.0.1
Containers 8.0.7
http proxy on localhost

doesn't work

@srinidhibs
Copy link

Updated to 8.0.7. Proxy settings didn't work - I was using http://localhost:8888 and then changed it to my http://my.local.ip.address:8888 and it still wouldn't work.

Downgraded back to 8.0.4 and disabled auto-update of the add-on. 😞

@crdx
Copy link

crdx commented May 9, 2022

@srinidhibs

The fix that closed this issue hasn't been released yet.

@bakulf
Copy link
Collaborator

bakulf commented May 9, 2022

Can somebody help me to reproduce the issue? I'm happy to work on it and include the fix in the next release.
I guess you all are using the latest stable firefox release, right?

@nekno
Copy link
Contributor

nekno commented May 9, 2022

Yes — using the latest stable Firefox, now 100.0, on macOS 12.3.1.

The broken versions (8.0.5, 8.0.6, 8.0.7) try to set a property on an http proxy that's meant for a socks proxy, so they actually break the http proxying functionality of the extension altogether.

When a container is set to route through an http proxy, if the destination is reachable without the proxy, the page will load in Firefox, but the traffic isn't routed through the proxy.

If the destination is unreachable without the proxy, the page will fail to load when a broken version of the extension is installed.

So testing is a matter of seeing a page load and traffic appear in the proxy (working) or not (broken).

  1. Run an http proxy somewhere on your LAN, e.g., install Proxyman on your localhost
  2. Configure the proxy to capture all traffic for all hosts
  3. Install Multi-Account Containers v8.0.7
  4. Set the proxy for one of your containers to your http://{host}:{port}
  5. Load any page using the container
    • Verify: No network traffic appears in the http proxy
  6. Install the fixed version of Multi-Account Containers
  7. Reload the page using the container
    • Verify: Network traffic appears in the http proxy

@davidistheuser
Copy link

still an issue with running on mac 13.1 and latest firefox with 8.0.9 Firefox Multi-Account Containers

@nekno
Copy link
Contributor

nekno commented Dec 31, 2022

For reasons passing understanding, and despite this being a blocker for this use case, the issue was fixed in #2333 and merged to the main branch 8 months ago but has not been included in an official release.

  • v8.0.7 was released on Apr 6.
  • The issue was resolved on Apr 25.
  • v8.0.8, v8.1.0, and v8.1.1 are all still marked as pre-release status.
  • v8.0.9 is the only release since the issue was resolved, and it only includes styling updates for Firefox 107.

We wait and we wonder. 🤷

@dannycolin
Copy link
Collaborator

8.0.9 was a hotfix for the broken styling in the confirmation page
8.1.x isn't released because it needs to get the greenlight from the QA team and get reviewed on addons.mozilla.org. However, it's the holidays so the staff isn't working.

@mozilla mozilla locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something is broken! Component: Proxy Issues related to the proxy functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.