Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save reference to watcher in FileSystemLoader for async shutdown #1476

Open
lcrosetto opened this issue Oct 2, 2024 · 0 comments
Open

Save reference to watcher in FileSystemLoader for async shutdown #1476

lcrosetto opened this issue Oct 2, 2024 · 0 comments

Comments

@lcrosetto
Copy link

FileSystemLoader does not keep a reference to the watcher:

const watcher = chokidar.watch(paths);

It would help to save the reference (to enable synchronous shutdown of chokidar with watcher.close()), as is done in NodeResolveLoader:

this.watcher = chokidar.watch();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant