Skip to content
This repository has been archived by the owner on Jul 16, 2019. It is now read-only.

Added npm run rsync-built-files-to-adjacent-openwpm-repo #43

Closed
wants to merge 1 commit into from

Conversation

motin
Copy link
Contributor

@motin motin commented May 9, 2019

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

An npm run command for fast syncing of the built files into the OpenWPM extension's node_modules folder, which speeds up testing of modified instrumentation during development.

  • What is the current behavior? (You can also link to an open issue here)

Testing changes in the instrumentation requires modifying package.json or using npm link, which conflicts with webpack/typescript module resolution.

  • What is the new behavior (if this is a feature change)?

After modifying the instrumentation, one can run npm run build && npm run rsync-built-files-to-adjacent-openwpm-repo in the openwpm-webext-instrumentation repo, followed by ./build-extension.sh in the adjacent OpenWPM repo, to have a local OpenWPM setup that uses the modified instrumentation.

@nhnt11
Copy link

nhnt11 commented May 28, 2019

I think there are better solutions than rsync. Monorepo is one; another is to use a local dependency in package.json in the extension.

@motin
Copy link
Contributor Author

motin commented Jun 27, 2019

Closing this in favor of short-term monorepo openwpm/OpenWPM#300

@motin motin closed this Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants