-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Dict.get
with Dict.getArray
at one spot in src/core/function.js
#9734
Labels
Comments
On this. Will fix and submit a PR in a few minutes. |
Hello is this still open or should it be closed because a pr was already made |
Can anybody help me get started please :) I would love to contribute.just a rookie in javascript |
There is already a pull request for this issue above, but feel free to work on another open issue if that's not being worked on yet. Thanks. |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was recently sorting through and throwing out old notes, when I found this and figured it wouldn't hurt to at least submit an issue.
Please refer to pull request #7295 for the background. Basically that PR missed one spot, so at
pdf.js/src/core/function.js
Line 189 in 7ba5044
get
should be replaced withgetArray
(which could help avoid future bugs).Since this issue ought to be a good candidate for the
5-good-beginner-bug
label, I'm including a link to https://github.com/mozilla/pdf.js/wiki/Contributing for good measure.The text was updated successfully, but these errors were encountered: