From 4db01746d8e7dc2c5aa86d584db285b4f28e1c50 Mon Sep 17 00:00:00 2001 From: Henrik Skupin Date: Wed, 25 Oct 2023 10:37:43 +0200 Subject: [PATCH 1/2] Run integration tests with WebDriver BiDi instead of CDP for Firefox. --- test/test.mjs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/test.mjs b/test/test.mjs index f706c81c8e28e..d144432cc540f 100644 --- a/test/test.mjs +++ b/test/test.mjs @@ -937,6 +937,10 @@ async function startBrowser({ browserName, headless, startUrl }) { } if (browserName === "firefox") { + // Run tests with the WebDriver BiDi protocol enabled only for Firefox for + // now given that for Chrome further fixes are needed first. + options.protocol = "webDriverBiDi"; + options.extraPrefsFirefox = { // avoid to have a prompt when leaving a page with a form "dom.disable_beforeunload": true, From d04d28a56d1454d2721513b451223c2333ffb8e3 Mon Sep 17 00:00:00 2001 From: Henrik Skupin Date: Fri, 8 Dec 2023 21:59:18 +0100 Subject: [PATCH 2/2] Remove unnecessary loop for closing open pages --- test/test.mjs | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/test.mjs b/test/test.mjs index d144432cc540f..711adfa01e99e 100644 --- a/test/test.mjs +++ b/test/test.mjs @@ -1056,9 +1056,6 @@ async function closeSession(browser) { continue; } if (session.browser !== undefined) { - for (const page of await session.browser.pages()) { - await page.close(); - } await session.browser.close(); } session.closed = true;