From 6e4b7ee3f8618001414e1629a4ac876fb3322b82 Mon Sep 17 00:00:00 2001 From: Calixte Denizet Date: Mon, 9 Sep 2024 21:28:59 +0200 Subject: [PATCH] [Editor] Avoid to have the ML disclaimer when the ML engine isn't ready (bug 1917543) --- test/integration/stamp_editor_spec.mjs | 23 +++++++++++++++++++++++ web/new_alt_text_manager.js | 1 + 2 files changed, 24 insertions(+) diff --git a/test/integration/stamp_editor_spec.mjs b/test/integration/stamp_editor_spec.mjs index c1b90b4dc08e8..7c71153da67f8 100644 --- a/test/integration/stamp_editor_spec.mjs +++ b/test/integration/stamp_editor_spec.mjs @@ -1096,5 +1096,28 @@ describe("Stamp Editor", () => { await page.waitForSelector("#newAltTextDialog", { visible: false }); } }); + + it("must check the new alt text flow (part 3)", async () => { + // Run sequentially to avoid clipboard issues. + for (const [, page] of pages) { + await page.evaluate(() => { + window.PDFViewerApplication.mlManager.enableAltTextModelDownload = false; + }); + + await switchToStamp(page); + + // Add an image. + await copyImage(page, "../images/firefox_logo.png", 0); + const editorSelector = getEditorSelector(0); + await page.waitForSelector(editorSelector); + await waitForSerialized(page, 1); + + // Wait for the dialog to be visible. + await page.waitForSelector("#newAltTextDialog", { visible: true }); + + // Check we haven't the disclaimer. + await page.waitForSelector("#newAltTextDisclaimer[hidden]"); + } + }); }); }); diff --git a/web/new_alt_text_manager.js b/web/new_alt_text_manager.js index 9a61f788406dc..3ac259a0551f4 100644 --- a/web/new_alt_text_manager.js +++ b/web/new_alt_text_manager.js @@ -346,6 +346,7 @@ class NewAltTextManager { this.#firstTime = firstTime; let { mlManager } = uiManager; let hasAI = !!mlManager; + this.#toggleTitleAndDisclaimer(); if (mlManager && !mlManager.isReady("altText")) { hasAI = false;