Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query validation in BigQuery data source does not update when you stop typing #975

Open
mreid-moz opened this issue Jul 18, 2019 · 0 comments

Comments

@mreid-moz
Copy link

Issue Summary

When typing a query using a BigQuery data source, the just-in-time query validation does not do a final validation when you finish typing. So if it shows an error by running before you're finished, it will not update after correcting it. You can force it to update by typing a dummy space.

Steps to Reproduce

  1. Select BigQuery (Beta) data source
  2. Type the following partial query: SELECT locale FROM telemetry.clients_daily WHERE submission_date_s3 = '2019-07-10 LIMIT 10 (note the missing closing single quote)
  3. Wait for the error message to appear: "Syntax error: Unclosed string literal at [1:71]"
  4. Add the missing closing quote character to end up with: SELECT locale FROM telemetry.clients_daily WHERE submission_date_s3 = '2019-07-10' LIMIT 10
  5. Observe that the error message persists
  6. Type a dummy space somewhere in the query
  7. Observe that the error message goes away and the query is now validated as it should have been after step 4.

Note that the same behaviour happens if the query successfully validates, then you remove that closing quote character again -- you see the "query will process X bytes" success message, even though the query is invalid. Typing a few more dummy characters will trigger re-validation.

Technical details:

  • Redash Version: 7.0.0+b5564-m21
  • Browser/OS: Firefox Nightly 70.0a1 on Mac OS Mojave
  • How did you install Redash: I didn't, but maybe noteworthy that this problem pre-dates the recent migration to GCP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant