Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential backoff for query retry has no upper limit #977

Open
mreid-moz opened this issue Jul 19, 2019 · 1 comment
Open

Exponential backoff for query retry has no upper limit #977

mreid-moz opened this issue Jul 19, 2019 · 1 comment

Comments

@mreid-moz
Copy link

mreid-moz commented Jul 19, 2019

Issue Summary

Per Bug 1565659, a scheduled query failed several times in a row and got itself into a state where, due to exponential backoff, it would not try again for 6 months. For a query that is expected to run every day, this is no good.

An upper bound of 24hrs (or the query refresh interval, whichever is larger) seems reasonable.

Steps to Reproduce

  1. Write a query, run it on a scheudule
  2. Cause this query to fail several times in a row (exercise to the reader)
  3. Fix the thing that was causing failures
  4. wait 6 months for the next scheduled update.

Technical details:

  • Redash Version: prod deployed at sql.telemetry.mozilla.org
  • Browser/OS: Nightly 70 / MacOS Mojave
  • How did you install Redash:
@jezdez
Copy link

jezdez commented Aug 2, 2019

This would definitely be a feature we would want to propose upstream since it's a pretty central part of Redash and I'd rather not mock around with those internals in the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants