Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustpkg should use workcache #7075

Closed
catamorphism opened this issue Jun 12, 2013 · 3 comments
Closed

rustpkg should use workcache #7075

catamorphism opened this issue Jun 12, 2013 · 3 comments

Comments

@catamorphism
Copy link
Contributor

Sub-bug of #5677

rustpkg build should "work like make": it should only rebuild files whose dependencies have changed. (Currently, it rebuilds everything every time.) Doing this will involve using workcache, which has its own set of issues (see #4432).
@ghost ghost assigned catamorphism Jun 12, 2013
@huonw
Copy link
Member

huonw commented Jul 30, 2013

Visiting for triage; some improvements to workcache landed in #7885 (but #4432 is still open, and there are still a pile of FIXMEs in it).

@graydon graydon mentioned this issue Aug 14, 2013
Closed
@catamorphism
Copy link
Contributor Author

#9034 will close this.

@catamorphism
Copy link
Contributor Author

#9034 closed this. If other issues arise, file a more specific bug.

@catamorphism catamorphism removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 22, 2021
@bors
Auto merge of rust-lang#7075 - xFrednet:7054-fp-branches-sharing-code…
eaf0f3d 
…, r=camsteffen,flip1995

Fixing FPs for the `branches_sharing_code` lint

Fixes rust-lang#7053
Fixes rust-lang#7054
And an additional CSS adjustment to support dark mode for every inline code. It currently only works in paragraphs, which was an oversight on my part 😅. [Current Example](https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name)

This also includes ~50 lines of doc comments and is therefor not as big as the changes would indicate. 🐧

---

changelog: none

All of these bugs were introduced in this dev version and are therefor not worth a change log entry.

r? `@phansch`
cc: `@camsteffen` since you have a pretty good overview of the `SpanlessEq` implementation 🙃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catamorphism @huonw