Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aquire reports success when write to S3 Fails #1

Open
jparr opened this issue Nov 26, 2018 · 1 comment
Open

Aquire reports success when write to S3 Fails #1

jparr opened this issue Nov 26, 2018 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jparr
Copy link

jparr commented Nov 26, 2018

I configured .threatreponse.ini with an S3 bucket that does not exist and ran

ssm_acquire --instance_id i-XXXXXXX --region us-west-2 --acquire

The command reports success.

Expected behavior would be an error.

@andrewkrug andrewkrug added the bug Something isn't working label Nov 27, 2018
@andrewkrug
Copy link
Contributor

This is a pretty easy story to write. We should validate that S3 bucket exists after role assumption and before acquisition. If the bucket does not exist Raise() a custom exception.

Additionally good house keeping would also be to Raise() a custom exception based on the SSM RunCommand exit code for the script. ( Should in theory exit -1 for this kind of thing ) You can parse the response and raise.

@andrewkrug andrewkrug added the good first issue Good for newcomers label Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants