Skip to content
This repository has been archived by the owner on Mar 21, 2018. It is now read-only.

Do not use node require in renderer process #1529

Open
jsantell opened this issue Nov 6, 2016 · 0 comments
Open

Do not use node require in renderer process #1529

jsantell opened this issue Nov 6, 2016 · 0 comments

Comments

@jsantell
Copy link
Contributor

jsantell commented Nov 6, 2016

Currently we still use node in the renderer process, but should allow node stdlib's that are browserify-able via https://github.com/webpack/node-libs-browser, like assert, url, path, etc. and wire this up to our webpack build (maybe just change the target from electron renderer to browser? sure there's a few config things to do for this) to ensure we're not using any non-browserify-able node stdlibs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants