Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions do not change in size with ctrl++/ctrl+- (desktop browsers) #336

Open
apadhye opened this issue Jan 8, 2015 · 3 comments
Open

Comments

@apadhye
Copy link

apadhye commented Jan 8, 2015

We cannot use keyboard options to increase/decrease font size.

STR:

  • Create a video with captions.
  • Play the video and enable captions.
  • Use Ctrl+ or Ctrl- (Cmd+ and Cmd- if you are on a Mac) to increase/decrease browser text size.

Expected:

  • Caption size increases or decreases along with the rest of the browser text.

Actual:

  • Caption size remains the same.
@RickEyre
Copy link
Contributor

Hey @apadhye, thanks for your feedback. I think this might be a bug that better belongs on bugzilla. While parts of this issue most likely do touch this repo, most of it would probably be on the browser side.

@gkatsev
Copy link
Contributor

gkatsev commented Jan 20, 2015

We're seeing this particularly in videojs where we're using vttjs to implement captions. We weren't sure whether vttjs could do anything about it.

@RickEyre
Copy link
Contributor

RickEyre commented Feb 7, 2015

@gkatsev yeah, I'm unsure right now on what would be causing this. I don't really have much time to investigate either. I'd be curious to know how the browser effects the size change when hitting +/-. That would tell us a lot about if vtt.js could do anything about it.

vtt.js calculates the size of the cue boxes and font via a relative percentage of the containing box. So I would think it would pick up on it.. something is getting lost in the mix though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants