Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks for overriding default cue styles make this library no longer useable by client-side code #349

Open
gkatsev opened this issue Mar 16, 2016 · 1 comment

Comments

@gkatsev
Copy link
Contributor

gkatsev commented Mar 16, 2016

The change made in 352982f added a bunch of references to Services which is only available internally in firefox code. Makes it so that we can no longer use this library in client-side code.

@kepstin
Copy link

kepstin commented Mar 23, 2016

I don't think this is actually the case; all of the calls that reference the Services object in that commit are behind a check with if(typeof Services !== "undefined").

If you have an object named Services in your own code, I guess this might conflict, but otherwise it should still work fine in client-side code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants