Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_docker_dev.sh fails when the working directory contain spaces #856

Open
jackwherry opened this issue Nov 22, 2020 · 0 comments
Open

Comments

@jackwherry
Copy link

Someone in an online community I frequent got a "too many arguments" error from ssh-keygen after running run_docker_dev.sh. After a little investigating, it turned out that a directory in their pwd contained spaces, causing $(pwd) occurrences to become multiple words.

I'm pretty sure that this can be fixed by adding quotes around paths in the script. I'm not too familiar with this codebase, nor do I have a development setup on my current machine, so I didn't make a formal pull request. This issue might also be present in other scripts in this repo. I attached a version of the script that should fix the issue.

It might be a good idea to run these shell scripts through ShellCheck or another linter.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant