Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-built libsvm binaries using BinaryBuilder #53

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Conversation

aviks
Copy link
Contributor

@aviks aviks commented Jun 3, 2020

The build scripts are here. The build uses the released sources, and patches them for openmp use.

There is a corresponding PR to LIBLINEAR.jl

Fix #52

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #53 into master will decrease coverage by 0.94%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   84.10%   83.15%   -0.95%     
==========================================
  Files           4        4              
  Lines         195      190       -5     
==========================================
- Hits          164      158       -6     
- Misses         31       32       +1     
Impacted Files Coverage Δ
src/ScikitLearnAPI.jl 43.33% <ø> (ø)
src/ScikitLearnTypes.jl 100.00% <ø> (ø)
src/LIBSVM.jl 90.19% <87.50%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea6a304...53da1ed. Read the comment docs.

@aviks
Copy link
Contributor Author

aviks commented Jun 4, 2020

@mpastell this should be ready to merge. Let me know if you have concerns. Would be good to get this tagged, since there are multiple reports of build issues.

@cossio
Copy link

cossio commented Jun 5, 2020

Yes, please get this merged soon and tag a new release. Cannot use the package because of this issue.

@laborg
Copy link

laborg commented Jul 2, 2020

@mpastell It would be great if you could merge this PR!

@aviks
Copy link
Contributor Author

aviks commented Jul 2, 2020

I believe Matti is on vacation now, I'll ping him again once he's scheduled to be back.

@mpastell
Copy link
Contributor

Thanks @aviks, merged and sorry for the delay!

@mpastell mpastell merged commit 52373be into JuliaML:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install LIBSVM
5 participants