Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ciscoconfparse with factory=True doesn't do what you want (yet) #35

Closed
mpenning opened this issue Apr 17, 2015 · 2 comments
Closed

ciscoconfparse with factory=True doesn't do what you want (yet) #35

mpenning opened this issue Apr 17, 2015 · 2 comments
Assignees
Labels

Comments

@mpenning
Copy link
Owner

It seems that the factory=True code in models_cisco.py and models_asa.py is becoming somewhat popular. These days, I am getting bugs filed against it as much as regular ciscoconfparse code.

Sadly, there is a lot of work to do on the factory=True methods, and I am not convinced that the factory model for configuration lines is the right approach yet; this doesn't mean I will rip it out, but it certainly does mean I'm not done...

Please heed the warning at the top of the source code, until I work out the right direction to take this effort. As such, the code in models_cisco.py and models_asa.py might change... significantly.

### HUGE UGLY WARNING:
###   Anything in models_cisco.py could change at any time, until I remove this
###   warning.  I have good reason to believe that these methods are stable and 
###   function correctly, but I've been wrong before.  There are no unit tests
###   for this functionality yet, so I consider all this code alpha quality. 
###
###   Use models_cisco.py at your own risk.  You have been warned :-)

All that said, I don't mind bugs filed against factory=True; I definitely want to know what to prioritize.

@github-actions
Copy link

This issue has automatically been marked stale due to inactivity. The issue will close unless further activity occurs. Please understand that the CiscoConfParse team is not obligated to comment on every issue. For more detailed information, please refer to our CONTRIBUTING guidance.

@github-actions github-actions bot added the stale label Jan 13, 2022
@github-actions
Copy link

Due to inactivity, CiscoConfParse's maintainers are closing this issue. Please refrain from further comments. In the future, CiscoConfParse's maintainers may reopen it solely at their own discretion. For more detailed information, please refer to our CONTRIBUTING guidance -> https://github.com/mpenning/ciscoconfparse/blob/master/.github/CONTRIBUTING.md

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant