-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: websocket-streams to ws #1108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoDaMa
changed the title
feat: websocket-streams to ws
[!WIP!] feat: websocket-streams to ws
May 29, 2020
YoDaMa
force-pushed
the
ws
branch
2 times, most recently
from
August 6, 2020 17:08
3eec98c
to
70e21c8
Compare
YoDaMa
changed the title
[!WIP!] feat: websocket-streams to ws
feat: websocket-streams to ws
Aug 6, 2020
anthonyvercolano
requested review from
anthonyvercolano,
mcollina and
scarry1992
August 6, 2020 22:28
anthonyvercolano
approved these changes
Aug 6, 2020
the errors I'm seeing on Node version 10 are not consistent and are on functionality not related to streams, so I'm going to consider this passing. The flakiness of tests still needs to be improved... |
After this fix in v4.2 we are getting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.