Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade help-me to v5.0.0 to resolve Missing Release of Resource after Effective Lifetime #1770

Closed
jackbridger opened this issue Jan 4, 2024 · 3 comments · Fixed by #1773

Comments

@jackbridger
Copy link
Contributor

jackbridger commented Jan 4, 2024

In summary: [email protected][email protected][email protected][email protected] (CWE-772)

If it helps, I would be happy to make a PR with help-me v5.0.0

@robertsLando
Copy link
Member

@jackbridger Do it, thanks

@jackbridger
Copy link
Contributor Author

jackbridger commented Jan 8, 2024

@jackbridger Do it, thanks

Thanks @robertsLando

It's likely my own environment (I'm debugging) but just wanted to check in case I'm missing anything while running locally:

I'm getting a node mismatch where when I run:
node -v (v20.10.0)
But when I run npm run test, I can see it's using v16.10.0. So it fails because node:test is not available
Error [ERR_UNKNOWN_BUILTIN_MODULE]: No such built-in module: node:test

Edit: it was a node version issue

@robertsLando
Copy link
Member

Node test runner requires node 18+. I was going to drop node 16 but I had to keep it as I didn't want to do a new major just for that, I have some other things in mind for next major

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants