-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reschedule pings problem #1904
fix: reschedule pings problem #1904
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1904 +/- ##
==========================================
+ Coverage 80.96% 81.25% +0.28%
==========================================
Files 24 24
Lines 1408 1467 +59
Branches 331 350 +19
==========================================
+ Hits 1140 1192 +52
- Misses 185 188 +3
- Partials 83 87 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add also a test to cover this and fix lint issues: npm run lint-fix
Test info: https://github.com/mqttjs/MQTT.js/blob/main/DEVELOPMENT.md#tests
Thanks for reviewing. I fix these and add test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are good now and code too, just fix lint issues please: npm run lint-fix
Fixes #1903