Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reschedule pings problem #1904

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

k-keisuke
Copy link
Contributor

@k-keisuke k-keisuke commented Jul 18, 2024

Fixes #1903

@k-keisuke k-keisuke changed the title Fix reschedule pings problem fix: reschedule pings problem Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.25%. Comparing base (9fc79df) to head (74a4bcc).
Report is 39 commits behind head on main.

Files Patch % Lines
src/lib/client.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
+ Coverage   80.96%   81.25%   +0.28%     
==========================================
  Files          24       24              
  Lines        1408     1467      +59     
  Branches      331      350      +19     
==========================================
+ Hits         1140     1192      +52     
- Misses        185      188       +3     
- Partials       83       87       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add also a test to cover this and fix lint issues: npm run lint-fix

Test info: https://github.com/mqttjs/MQTT.js/blob/main/DEVELOPMENT.md#tests

src/lib/client.ts Outdated Show resolved Hide resolved
src/lib/handlers/index.ts Outdated Show resolved Hide resolved
@k-keisuke
Copy link
Contributor Author

Thanks for reviewing. I fix these and add test.

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

robertsLando
robertsLando previously approved these changes Jul 18, 2024
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are good now and code too, just fix lint issues please: npm run lint-fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Keepalive timeout error always occurs when reschedulePings == false.
3 participants