Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename errors() to catchError() #96

Open
mrWh1te opened this issue Feb 19, 2021 · 3 comments
Open

rename errors() to catchError() #96

mrWh1te opened this issue Feb 19, 2021 · 3 comments
Labels
botaction npm Packaging, Releases, Dist related

Comments

@mrWh1te
Copy link
Owner

mrWh1te commented Feb 19, 2021

Describe the bug
The current name, while relevant, isn't very clear as to the function of the BotAction

@mrWh1te
Copy link
Owner Author

mrWh1te commented Feb 19, 2021

going forward, deprecate errors()() in next minor/patch release then delete in next major release

@mrWh1te mrWh1te added botaction npm Packaging, Releases, Dist related labels Feb 19, 2021
@mrWh1te mrWh1te changed the title rename errors() to catchErrors() rename errors() to catchError() Mar 3, 2021
@mrWh1te
Copy link
Owner Author

mrWh1te commented Mar 3, 2021

unrelated, but it would be nice to add a function or something that runs and returns a value in the event an error is caught

for example, catch an error -> return an abort line signal -> restart bot with different initial pipe value

@mrWh1te
Copy link
Owner Author

mrWh1te commented Mar 4, 2021

for any devs who recognize the striking similarity between this and rxjs catchError().....

what can i say, i like the library 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
botaction npm Packaging, Releases, Dist related
Projects
None yet
Development

No branches or pull requests

1 participant