Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag-n-drop support #4

Closed
greenozon opened this issue Aug 28, 2024 · 8 comments
Closed

Drag-n-drop support #4

greenozon opened this issue Aug 28, 2024 · 8 comments

Comments

@greenozon
Copy link

Not sure how exactly it works now, it seems try to accept dropped media files, but then nothing happens
seen when something is playing and you drop over media file

Another nice to have & user-friendly feature :)

@greenozon
Copy link
Author

after some d-n-d games I hit the silent crash ....

pic from dump:

image

@mrfearless
Copy link
Owner

Ok, thanks for letting me know. I will look into this further. In theory it should work like the main screen when first loaded, accepting drag and drop, checking if a file is already playing, stopping it, releasing the media item, then processing the dropped file, setting the title etc, setting it in the queue and then playing it. Its possible that something isn't being taken into account properly somewhere. If you are able to reproduce it exactly that might help, otherwise it may be some handles or memory being leaked somewhere if its more random and hard to pin down.

@greenozon
Copy link
Author

again, everything is all around this.. - #2
you could skip it if it's not planned

@mrfearless
Copy link
Owner

Found that I wasn't calling DragFinish after calls to DragQueryFile, so a memory leak there. Should be fixed in next version which will have Unicode support, which should also fix some of the issues raised.

@greenozon
Copy link
Author

are there any plans for releasing patch build soon?

@mrfearless
Copy link
Owner

Let me know if the latest version resolves some of these issues, and if so we can then close them. Thanks.

@greenozon
Copy link
Author

great news! I'll try to test it out today and get back

@greenozon
Copy link
Author

tested, can't reproduce
conclusion: well done!
closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants