Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #36

Open
lovasoa opened this issue Sep 19, 2018 · 4 comments
Open

Improve error handling #36

lovasoa opened this issue Sep 19, 2018 · 4 comments

Comments

@lovasoa
Copy link
Contributor

lovasoa commented Sep 19, 2018

Currently, when parse fails, the user only gets a very uninformative error string as a result.
It would be nice to have a custom error type with useful functionality , such as knowing where the error happened.

@lovasoa
Copy link
Contributor Author

lovasoa commented Sep 19, 2018

See lovasoa@a0e27ac

@ms705
Copy link
Owner

ms705 commented Oct 3, 2018

Yes! I've been meaning to add support for more descriptive syntax errors for a while, but never got around to it. Independently, I believe nom's story for parse error handling has also changed, however, so it might be best do to this alongside a port to nom v4.

@ms705
Copy link
Owner

ms705 commented Oct 3, 2018

(Though I like the changed you linked; we can certainly merge that one right away.)

@tomharmon
Copy link
Contributor

To add to this issue: Specifically we should use nom's VerboseError to improve error messages. One thing pointed out by @spazm is that in src/create.rs, the creation function, might want to through a nom error with descriptive error message rather than the existing assert!(table.alias.is_none())

@tomharmon tomharmon mentioned this issue Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants