Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation doesn't explicitly explain what packInt / packByte / etc do #483

Open
Ben-Cutler opened this issue Sep 9, 2018 · 0 comments
Labels

Comments

@Ben-Cutler
Copy link

I hit an issue a few days ago with the fact that the MessageBufferPacker's packInt method (and other pack methods ) pack a number to take as little space on the wire as possible (So your i32 could be serialized as a u16, a u8,i8, etc) . This caused an issue with another library that was type sensitive.

While this is a reasonable implementation, the documentation here
https://static.javadoc.io/org.msgpack/msgpack-core/0.8.2/org/msgpack/core/MessagePacker.html
Should mention that packInt , packByte , etc do not guarantee the binary header of that type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants