Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to customize a post's hero #42

Open
andy-wojciechowski opened this issue Sep 15, 2019 · 4 comments
Open

Add the ability to customize a post's hero #42

andy-wojciechowski opened this issue Sep 15, 2019 · 4 comments
Assignees

Comments

@andy-wojciechowski
Copy link
Member

andy-wojciechowski commented Sep 15, 2019

Currently posts created with the post editor are limited to the following background image: https://source.unsplash.com/collection/145103/. We should add the ability to change the background image since not all posts currently on the SSE website use that background image. The hero would not be a required field to submit a post, just an option for a user to add customization to their post and we could fall back to the hero that we're using currently if they don't supply a hero.

There are a couple of ways we could implement this customization. My thought is we would break it into 2 phases.

Phase 1: Add the ability for a custom hero from a URL. This would be the most easy customization we could add. This would involve a textbox for a user to paste an image URL into and then we would substitute that URL when we format the post.

Phase 2: Add the ability for a custom hero based on an image file. This would be the more complicated phase. We could build on our existing image filesystem using carrierwave and add drag and drop support to this textbox or add an upload button. That custom image file would then need to be committed to the website's asset folder.

@andy-wojciechowski andy-wojciechowski added the question Further information is requested label Sep 15, 2019
@andy-wojciechowski andy-wojciechowski self-assigned this Sep 15, 2019
@andy-wojciechowski
Copy link
Member Author

@GFLEMING133 I assigned myself to this issue to handle Phase 2, but somebody else could also easily be assigned to this issue to implement phase 1 of this issue.

@GFLEMING133
Copy link
Member

GFLEMING133 commented Sep 15, 2019

Yes, I think phase 1 would be an excellent choice for a newer developer. It's a relatively simple feature and it should be easily testable. Phase 2 might be more complex, but it would be a good opportunity for you to work with a newer developer and show them how CarrierWave works, so that in the future we have more than 1 person who knows how the image handling works.

@andy-wojciechowski
Copy link
Member Author

That's a good point, I'll still leave my name on this issue to show how CarrierWave works to a newer developer then.

@andy-wojciechowski andy-wojciechowski removed the question Further information is requested label Sep 15, 2019
@andy-wojciechowski
Copy link
Member Author

This first phase of this issues is done. It was released on 10/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants