Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use api feature of wholesym 0.7.0 #340

Open
afranchuk opened this issue Aug 20, 2024 · 2 comments
Open

Cannot use api feature of wholesym 0.7.0 #340

afranchuk opened this issue Aug 20, 2024 · 2 comments

Comments

@afranchuk
Copy link
Contributor

When enabling the api feature of wholesym version 0.7.0, it depends on samply-api 0.23.2 (which incidentally isn't pushed in the repo?). This uses samply-symbols 0.22, however wholesym uses samply-symbols 0.23, so it fails to compile at the Api creation site. Since samply-api 0.23.1 was yanked (which was the first to use samply-symbols 0.23), there's no workaround here.

@mstange
Copy link
Owner

mstange commented Aug 20, 2024

Ugh, sorry about the mess. samply-api 0.23.2 should be in the repo, but maybe on a non-main branch?
If you can figure out the simplest steps to fix it, I can spend some time going through those steps, but I can't promise prompt service for another week or so

@afranchuk
Copy link
Contributor Author

No worries, I've backed up to wholesym 0.5.0 for the time being. If I have time I will try to put together a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants