Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming which to where #65

Closed
kimroen opened this issue Apr 13, 2021 · 2 comments · Fixed by #68
Closed

Consider renaming which to where #65

kimroen opened this issue Apr 13, 2021 · 2 comments · Fixed by #68

Comments

@kimroen
Copy link

kimroen commented Apr 13, 2021

The property used to filter in mswjs/data is named which, citing being heavily inspired by Prisma. However, Prisma does not use which, it uses where:

https://www.prisma.io/docs/concepts/components/prisma-client/filtering-and-sorting

Is it possible that this is a mistake?

where is also the preferred word for other ORMs (presumably because the keyword is WHERE in SQL), such as:

Non-js:

@kettanaito
Copy link
Member

Thank you for reporting this, @kimroen. You're absolutely right, and the which choice is an oversight on my part (@msutkowski has also pointed this out). I think we should adopt where instead.

Please, would you be interested in shipping this change?

@kimroen
Copy link
Author

kimroen commented Apr 15, 2021

Wonderful 👍 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants