-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature f32 #8
Feature f32 #8
Conversation
Hi and thank you for your contribution (as well as for showing your example use case!). I'll take a closer look and let you know if needed, or merge it and make a new release otherwise. |
I took a closer look at your code and I was wondering : do you have any particular reasons for using the "Float" crate? I feel that by using the "num-traits" crate we could also make the code generic on f32 and f64, without this functionality being under a specific feature flag. In most of the code, I guess it's a matter of changing the function signatures ( In fact, the "geo_types" crate (and therefore also "geo") uses "num-traits" to manage genericity over f32/f64 types. What do you think about it ? Anyway, I also think it would also be a good thing to be able to use this crate indifferently with f32 or f64 ! |
I didn't use any crate, just:
|
Perhaps the more generic T route would be more idiomatic, I kinda went as simple as possible :), feature-gated it and made it so it doesn't break anything. So yes, |
Indeed, sorry for the confusion ! Using I'll merge your PR and make a new release. Maybe in a future release I'll integrate num-traits. |
great! Thanks :) |
Published on crates.io. |
Hi, thanks for this library.
I needed
f32
version, so I thought I'd PR it also.Let me know if this won't do :D