Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters being saved across separate queries causing unexpected missing results #1346

Open
pkkid opened this issue Jun 13, 2024 · 0 comments
Open
Labels

Comments

@pkkid
Copy link

pkkid commented Jun 13, 2024

Describe the bug
Filters being saved across separate queries causing unexpected missing results.

To Reproduce (Scenario 1)

  1. Create new SQL file with two simple queries similar to the following:
    SELECT jobname, jobid FROM jenkins_piperun;
    SELECT count(*) FROM jenkins_piperun;
  2. Put cursor on the first query run command "SQLTools Connection: Run Current Query"
  3. Note the results, and add a simple filter to one of the columns. I filtered a column with comma ",".
  4. Put cursor on the second query run command "SQLTools Connection: Run Current Query"
  5. NOTE the result on the count(*) query is No Data.
  6. The only way to get data back is to rerun the first query and remove the filter.

To Reproduce (Scenario 2)

  1. Create new SQL file with two simple queries similar to the following:
    SELECT jobname, jobid FROM jenkins_piperun;
    SELECT count(*) FROM jenkins_piperun;
  2. Run the command "SQLTools Connection: Run This File"
  3. Note the results, and add a simple filter to one of the columns on the first query result. I filtered a column with comma ",".
  4. When there is a filter on the first query result, the second query result will show No Data.
  5. The only way to get data back on the second query is to remove the filter on the first query.

Expected behavior

  • Would expect filters on one query to not affect results of another query. This is especially bad for scenario 1 above as there is no visible on-screen way to fix yourself unless you actively re-run the first query to remove the filter; but no one would expect to have to do that.

Desktop (please complete the following information):

  • SQLTools Version v0.28.3
  • SQLTools SQLite v0.5.1
  • VS Code Version: 1.90.0
  • OS: Ubuntu 24.04
  • Driver: SQLite
  • Database version: 3.45.1
  • Maybe applicable, I have the setting: "sqltools.results.reuseTabs": "connection"
@pkkid pkkid added the triage label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant