Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release ? #43

Open
simonmichael opened this issue Oct 25, 2022 · 6 comments
Open

release ? #43

simonmichael opened this issue Oct 25, 2022 · 6 comments

Comments

@simonmichael
Copy link

@muesli4, thanks for table-layout! It sounds powerful. We are thinking of using it to replace home-grown code in hledger. I see @Xitian9 has a bunch of PRs pending, the last release was in 2020, and the package seems to not yet have reached stackage. I wonder are you planning a release some time soon, or are you perhaps busy and open to help, eg a comaintainer or release manager ?

@muesli4
Copy link
Owner

muesli4 commented Oct 25, 2022

I apologize for the delay. And most of all it is not fair to @Xitian9. There are circumstances in my life over which I have no control and that eat up my time. Usually I spend every day coding at work, so at the end of the day I simply lack the focus. That being said I tried to review most of the open pull requests.

I wonder are you planning a release some time soon, or are you perhaps busy and open to help, eg a comaintainer or release manager ?

I was planning to do it a long time ago and failed. My suggestion is that we get all of the pull requests in. I don't have any fundamental issues with any of those. Quite the opposite, I think they are good work and an enrichment to the library.

However, I would consider making @Xitian9 comaintainer if he is willing to do that job. I consider reviews as mandatory and am a bit pedantic. But after all I want to write quality software that works and is well-document.

@simonmichael
Copy link
Author

simonmichael commented Oct 26, 2022

No apology needed, I fully understand. I'm hoping @Xitian9 might get some time to help - he does great work. I don't know much about the lib yet but I will try to do a little bit of review on the PRs as well.

@muesli4
Copy link
Owner

muesli4 commented Oct 29, 2022

Any help is welcome. Considering a release on stackage: I do not see any issues from my side. But unfortunately we have a dependency on the default packages. Technically, I could publish the Default instances as a separate package. But maybe that creates more problems than it solves.

@simonmichael
Copy link
Author

Do you mean the data-default-* packages ? Those are in stackage.

@muesli4
Copy link
Owner

muesli4 commented Oct 29, 2022

I see, then the issue was not updated. By the way, see #12. I will try to do this after the hackage release.

@muesli4
Copy link
Owner

muesli4 commented Oct 29, 2022

@Xitian9 I started going through commits to update CHANGELOG.md. I will then give review to you to make sure your changes are covered and contain everything you want to see there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants