[Autocomplete] Improve accessibility #18204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
accessibility
oliviertassinari
commented
Nov 5, 2019
|
|
||
| ### iOS VoiceOver | ||
|
|
||
| VoiceOver on iOS Safari doesn't support the `aria-owns` attribute very well. |
There was a problem hiding this comment.
@fymmot do you know if there is a bug we can link, like https://bugs.webkit.org/show_bug.cgi?id=176896?
There was a problem hiding this comment.
@oliviertassinari I haven't been able to find a bug for this. I might file one myself.
There is some info in this article (https://tink.uk/using-the-aria-owns-attribute/), near the bottom concerning screen reader support. It's a little bit dated (2015) but there hasn't been any improvements for iOS VoiceOver since then.
There was a problem hiding this comment.
Missing data on a11ysupport.io: https://a11ysupport.io/tech/aria/aria-owns_attribute
powermapper.com: https://www.powermapper.com/tests/screen-readers/aria/
Concerning VoiceOver on iOS I wouldn't put too much time into it. According to powermapper their support is unreliable (59% vs >80% of jaws or nvda) and VoiceOver is stagnating at 12% (https://webaim.org/projects/screenreadersurvey8/) without data on iOS vs macOS for VoiceOver (so it's likely below 10% for VoiceOver + iOS)
There was a problem hiding this comment.
@eps1lon
I have to differ here. I would argue that iOS VoiceOver is one of, if not the, single most important screen reader to support.
The 12% number you quoted is for primary desktop screen reader, i.e. Mac VoiceOver. Further down in the survey, you see that 86% of users use a mobile screen reader, and that 71.2% of respondents say that they use iOS VoiceOver.
In my own experience as an accessibility consultant, the trend is that blind users increasingly prefer their phone over their desktop computer, or even stop using the latter completely.
There was a problem hiding this comment.
This might very well be true but this is the classic data vs anecdote argument. I will always use the data over the anecdote unless you can explain how the data is corrupted or how I'm misinterpreting it.
That being said I see now that I missed the mobile vs desktop usage. It's not very well listed how usage compares (either more, less or equal but not how big the difference is if it exists) but it's not that far fetched to assume they're about equal.
So yes it does make sense to work on these issues but we do have to recognize that supporting VoiceOver iOS will take more effort (see reliability), Thank you for pointing that out 👍
oliviertassinari
force-pushed
the
autocomplete-fix-accessibility
branch
from
432f7cb
to
ee62778
Compare
|
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Details of bundle changes.Comparing: f3b7eb7...ee62778
|
|
This will do the trick 👍 |
|
@eps1lon Thank you for sharing this survey. Very interesting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18191
cc @fymmot please review :)
https://5dc15b3f4c33eb00073ae599--material-ui.netlify.com/components/autocomplete/#useautocomplete