Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Fix control state error #18341

Merged
merged 1 commit into from
Nov 13, 2019
Merged

[TreeView] Fix control state error #18341

merged 1 commit into from
Nov 13, 2019

Conversation

joshwooding
Copy link
Member

Whoops. Don't copy and paste :P

@joshwooding joshwooding added bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Nov 12, 2019
oliviertassinari
oliviertassinari approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

Recently, I was wondering if we shouldn't abstract this logic. We start to see a common pattern emerge.

@joshwooding
Copy link
Member Author

@oliviertassinari I agree, I'm playing out with selection on the TreeView and there will need to be two warnings 🙈

@mui-pr-bot
Copy link

No bundle size changes comparing 24840a8...99041c7

Generated by 🚫 dangerJS against 99041c7

@oliviertassinari oliviertassinari merged commit 9eb38da into mui:master Nov 13, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@joshwooding joshwooding deleted the dont-copy-and-paste-kids branch January 28, 2020 23:16
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshwooding @mui-pr-bot @oliviertassinari