Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[utils] Simplify refType #18437

Merged
merged 1 commit into from
Nov 18, 2019
Merged

[utils] Simplify refType #18437

merged 1 commit into from
Nov 18, 2019

Conversation

NMinhNguyen
Copy link
Contributor

PropTypes does have a circular reference to itself via PropTypes property but I don't think we really want to use it?

https://github.com/facebook/prop-types/blob/1c4077b7455e037bd8f81f48e9c51d60c972f8e9/factoryWithTypeCheckers.js#L607

@eps1lon eps1lon added the package: utils Specific to the @mui/utils package label Nov 18, 2019
@eps1lon eps1lon changed the title [core] Simplify refType [utils] Simplify refType Nov 18, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing b93c199...1f785bc

Generated by 🚫 dangerJS against 1f785bc

@eps1lon eps1lon merged commit 15e3336 into mui:master Nov 18, 2019
@eps1lon
Copy link
Member

eps1lon commented Nov 18, 2019

@NMinhNguyen Thanks!

@NMinhNguyen NMinhNguyen deleted the patch-1 branch November 18, 2019 17:52
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
package: utils Specific to the @mui/utils package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NMinhNguyen @mui-pr-bot @eps1lon