Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[useMediaQuery] Fix ssrMatchMedia requiring listener mixin #18501

Merged
merged 3 commits into from
Nov 22, 2019
Merged

[useMediaQuery] Fix ssrMatchMedia requiring listener mixin #18501

merged 3 commits into from
Nov 22, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 22, 2019 •
edited
Loading

ssrMatchMedia in useMediaQuery does not implement the full window.matchMedia interface: no listeners, just matches.

Requires #18500
Part of #14897

@eps1lon eps1lon mentioned this pull request Nov 22, 2019
Closed
@eps1lon eps1lon added the on hold There is a blocker, we need to wait label Nov 22, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 22, 2019 •
edited
Loading

No bundle size changes comparing 7653673...5e18539

Generated by 🚫 dangerJS against 5e18539

@eps1lon eps1lon force-pushed the fix/useMediaQuery/ssrMatchMedia-type branch from 1ef2543 to 5e18539 Compare November 22, 2019 19:26
@eps1lon eps1lon removed the on hold There is a blocker, we need to wait label Nov 22, 2019
oliviertassinari
oliviertassinari approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@eps1lon eps1lon merged commit aa1705c into mui:master Nov 22, 2019
@eps1lon eps1lon deleted the fix/useMediaQuery/ssrMatchMedia-type branch November 22, 2019 19:48
eps1lon added a commit to eps1lon/material-ui that referenced this pull request Nov 25, 2019
@eps1lon
Add changeset for mui#18501
6f8ec0a
eps1lon added a commit to eps1lon/material-ui that referenced this pull request Nov 25, 2019
@eps1lon
Add changeset for mui#18501
75d3a56
eps1lon added a commit to eps1lon/material-ui that referenced this pull request Nov 25, 2019
@eps1lon
Add changeset for mui#18501
9da888c
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
This was referenced Feb 23, 2020
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
hook: useMediaQuery typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari